HyukjinKwon commented on code in PR #42745: URL: https://github.com/apache/spark/pull/42745#discussion_r1318078679
########## python/pyspark/sql/functions.py: ########## @@ -55,11 +55,13 @@ # Keep pandas_udf and PandasUDFType import for backwards compatible import; moved in SPARK-28264 from pyspark.sql.pandas.functions import pandas_udf, PandasUDFType # noqa: F401 + +# TODO: should directly rename the internal functions Review Comment: It's actually fine to don't rename. In practice, we only name underscore when the file is exposed as an API. `pyspark.sql.utils` isn't documented so it's fine. If those methods are used in other (internal) modules, we can just don't add `_` prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
