LuciferYang commented on code in PR #42168:
URL: https://github.com/apache/spark/pull/42168#discussion_r1318324551


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/orc/OrcPartitionReaderFactory.scala:
##########
@@ -163,13 +166,17 @@ case class OrcPartitionReaderFactory(
 
   private def createORCReader(filePath: Path, conf: Configuration): Reader = {

Review Comment:
   How about letting the existing createORCReader method return a (Reader, 
OrcTail)? Or can we rebuild a usable OrcTail from Reader? For example, new 
OrcTail(reader.getFileTail, reader.getSerializedFileFooter)?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to