HyukjinKwon commented on code in PR #42847:
URL: https://github.com/apache/spark/pull/42847#discussion_r1320902565
##########
sql/api/src/main/scala/org/apache/spark/sql/util/ArrowUtils.scala:
##########
@@ -118,6 +118,18 @@ private[sql] object ArrowUtils {
nullable = false,
timeZoneId,
largeVarTypes)).asJava)
+ case CalendarIntervalType =>
+ val fields = Seq(
Review Comment:
I mean, external ser/de with Arrow should use that corresponding types
ideally. Internal ser/de we can use our existing `getInterval` approach from
Arrow batch.
##########
sql/api/src/main/scala/org/apache/spark/sql/util/ArrowUtils.scala:
##########
@@ -118,6 +118,18 @@ private[sql] object ArrowUtils {
nullable = false,
timeZoneId,
largeVarTypes)).asJava)
+ case CalendarIntervalType =>
+ val fields = Seq(
Review Comment:
I mean, external ser/de with Arrow and Arrow schema should use that
corresponding types ideally. Internal ser/de we can use our existing
`getInterval` approach from Arrow batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
