Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6377#issuecomment-105041178
Hi @scwf thanks for finding this. So I dug into this a little bit -- looks
like this is just a little bit of ignorance on my part when creating the test.
I used "CST" to mean "Central Standard Time", eg., the timezone of Chicago,
because that's where I am. But if you're in Shanghai, "CST" will mean "China
Standard Time". The code is already time zone sensitive, the problem is just
ambiguity in the test.
I would like to have a test for some non-GMT timezone. How about we change
it to something non-ambiguous? If we can trust
http://www.timeanddate.com/time/zones/ we could use EST, which would make the
equivalent time "2015-02-20T18:21:17.190EST".
Btw, another mistake a made: for consistency, the test class really should
be `SimpleDateDateParamSuite`. Would you mind fixing that as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
