panbingkun commented on code in PR #42917:
URL: https://github.com/apache/spark/pull/42917#discussion_r1325314370
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -498,13 +498,13 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
origin = t.origin)
}
- def expectViewNotTableError(
+ def unsupportedTableOperationError(
Review Comment:
Well, this is the legacy issue,
The error class used by the another ·unsupportedTableOperationError` method
is `UNSUPPORTED_FEATURE.TABLE_OPERATION`.
The biggest difference between it and the current
`UNSUPPORTED_TABLE_OPERATION.WITH_SUGGESTION` is that the prompt is different.
- The `UNSUPPORTED_FEATURE.TABLE_OPERATION` is
https://github.com/apache/spark/blob/b6190a3db974c19b6a0c4fe7af75531d67755074/common/utils/src/main/resources/error/error-classes.json#L3218-L3222
- The `UNSUPPORTED_TABLE_OPERATION.WITH_SUGGESTION` is:
https://github.com/apache/spark/blob/b6190a3db974c19b6a0c4fe7af75531d67755074/common/utils/src/main/resources/error/error-classes.json#L3440-L3444
### Let me try to merge them together in this PR.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -498,13 +498,13 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
origin = t.origin)
}
- def expectViewNotTableError(
+ def unsupportedTableOperationError(
Review Comment:
Well, this is the legacy issue,
The error class used by the another ·unsupportedTableOperationError` method
is `UNSUPPORTED_FEATURE.TABLE_OPERATION`.
The biggest difference between it and the current
`UNSUPPORTED_TABLE_OPERATION.WITH_SUGGESTION` is that the prompt is different.
- The `UNSUPPORTED_FEATURE.TABLE_OPERATION` is
https://github.com/apache/spark/blob/b6190a3db974c19b6a0c4fe7af75531d67755074/common/utils/src/main/resources/error/error-classes.json#L3218-L3222
- The `UNSUPPORTED_TABLE_OPERATION.WITH_SUGGESTION` is:
https://github.com/apache/spark/blob/b6190a3db974c19b6a0c4fe7af75531d67755074/common/utils/src/main/resources/error/error-classes.json#L3440-L3444
### Let me try to merge them together in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
