juliuszsompolski commented on PR #42910: URL: https://github.com/apache/spark/pull/42910#issuecomment-1719194332
@jdesjean ah, actually there's a deeper reason why this can't be tested in SparkConnectService: This tests that queries become FINISHED, even though client does not consume results. As I wrote above, SparkConnectService works with mocks. One thing that this mock doesn't have is flow control. The server will be pushing results to the output stream, regardless if the client consumes them or not. So to test a "non-result-consuming client, we need a suite implementing `SparkConnectServerTest` that will use this real RPC communication. For now this suite is the only one using this new infra. Maybe let me spin it off in another suite, since it's not related to Reattachable execute indeed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
