juliuszsompolski commented on code in PR #42929:
URL: https://github.com/apache/spark/pull/42929#discussion_r1325924260
##########
python/pyspark/sql/connect/client/reattach.py:
##########
@@ -200,9 +200,6 @@ def _release_all(self) -> None:
This will send an asynchronous RPC which will not block this. The
client continues
executing, and if the release fails, server is equipped to deal with
abandoned executions.
"""
- if self._result_complete:
- return
Review Comment:
I'd rather remove line 114
https://github.com/apache/spark/pull/42929/files#diff-42a2895f9b799478210ca059e731fdbabf84042dddef97c203f90d5c5870aa3dR114
than the check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
