juliuszsompolski commented on code in PR #42908:
URL: https://github.com/apache/spark/pull/42908#discussion_r1326120502
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -139,7 +139,7 @@ object Connect {
"With any value greater than 0, the last sent response will always
be buffered.")
.version("3.5.0")
.bytesConf(ByteUnit.BYTE)
- .createWithDefaultString("1m")
+ .createWithDefaultString("10m")
Review Comment:
I would rather not be changing it in the suite, because that suite is
suppose to stress test how the actual client behaves when faced with
disconnects. If we changed it in the suite, that would be sweeping under the
carpet that I think from the experiments performed now that it was a bit too
small for retries robustness.
This is not a major issue, and this in practice only applies in situations
when connect faces real intermittent connectivity issues, where before this was
implemented, it would just fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
