Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6390#discussion_r30955804
--- Diff:
core/src/test/scala/org/apache/spark/serializer/KryoSerializerSuite.scala ---
@@ -62,6 +62,10 @@ class KryoSerializerSuite extends FunSuite with
SharedSparkContext {
val thrown3 = intercept[IllegalArgumentException](new
KryoSerializer(conf4).newInstance())
assert(thrown3.getMessage.contains(kryoBufferProperty))
assert(!thrown3.getMessage.contains(kryoBufferMaxProperty))
+ val conf5 = conf.clone()
+ conf5.set(kryoBufferProperty, "8m")
--- End diff --
Line 52 does, but I know that's an exception case, though it won't fail as
expected unless `m` is handled correctly. OK, it doesn't hurt to add this I
suppose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
