Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/6360#issuecomment-105062103
I'm not an expert on this code by any means. The problem description and
solution sound reasonable and match up with the change. I skimmed the change
and didn't see anything I'd flag. Tests pass. I'd love to get more Python folks
to look at it, like @davies (and I see @lianhuiwang is already looking too),
but this appears to be a good cleanup and problem solving change for 1.5 /
`master`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
