HyukjinKwon commented on code in PR #42965: URL: https://github.com/apache/spark/pull/42965#discussion_r1328227343
########## python/pyspark/sql/connect/client/reattach.py: ########## @@ -18,12 +18,11 @@ check_dependencies(__name__) +from threading import RLock import warnings import uuid from collections.abc import Generator from typing import Optional, Dict, Any, Iterator, Iterable, Tuple, Callable, cast, Type, ClassVar -from multiprocessing import RLock -from multiprocessing.synchronize import RLock as RLockBase from multiprocessing.pool import ThreadPool Review Comment: Yeah, this is actually a thread pool but it's under `multiprocessing` for some reasons. I took a look into the codes inside before. It should be safe to use threading.Rlock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
