amaliujia commented on code in PR #42971:
URL: https://github.com/apache/spark/pull/42971#discussion_r1328287604
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -1131,17 +1130,24 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog with QueryErrorsB
* remove extra project which only re-assign expr ids from the plan so that
we can identify exact
* duplicates metric definition.
*/
- private def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan
= {
+ def simplifyPlanForCollectedMetrics(plan: LogicalPlan): LogicalPlan = {
plan.resolveOperators {
case p: Project if p.projectList.size == p.child.output.size =>
- val assignExprIdOnly = p.projectList.zipWithIndex.forall {
+ var assignExprIdOnly = p.projectList.zipWithIndex.forall {
case (Alias(attr: AttributeReference, _), index) =>
// The input plan of this method is already canonicalized. The
attribute id becomes the
// ordinal of this attribute in the child outputs. So an
alias-only Project means the
// the id of the aliased attribute is the same as its index in the
project list.
attr.exprId.id == index
case _ => false
Review Comment:
It is surprising for me to find that `Alias` is an expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
