cloud-fan commented on code in PR #42967:
URL: https://github.com/apache/spark/pull/42967#discussion_r1329071470
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala:
##########
@@ -264,8 +269,7 @@ case class CachedRDDBuilder(
}
private def buildBuffers(): RDD[CachedBatch] = {
- val cb = if (cachedPlan.supportsColumnar &&
- serializer.supportsColumnarInput(cachedPlan.output)) {
+ val cb = if (supportsColumnarInput) {
serializer.convertColumnarBatchToCachedBatch(
Review Comment:
what's the default implementation for this? I'm wondering when users need to
care about input is columnar or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
