grundprinzip commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1329197325
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -3292,39 +3292,49 @@ def test_stop_session(self):
self.spark.conf.get("some.conf")
self._check_no_active_session_error(e.exception)
- def test_error_stack_trace(self):
- with self.sql_conf({"spark.sql.pyspark.jvmStacktrace.enabled": True}):
Review Comment:
Doesn't this effectively change the API? What is the expectation when the
user sets the SQL conf and moves from py4j to spark connect and back? Shouldn't
we retain the option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
