heyihong commented on code in PR #42377:
URL: https://github.com/apache/spark/pull/42377#discussion_r1329283591
##########
python/pyspark/sql/tests/connect/test_connect_basic.py:
##########
@@ -3292,39 +3292,49 @@ def test_stop_session(self):
self.spark.conf.get("some.conf")
self._check_no_active_session_error(e.exception)
- def test_error_stack_trace(self):
- with self.sql_conf({"spark.sql.pyspark.jvmStacktrace.enabled": True}):
Review Comment:
`spark.sql.pyspark.jvmStacktrace.enabled` is only used by spark connect
python client and the option still works with this change
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala:
##########
@@ -265,6 +271,12 @@ case class SessionHolder(userId: String, sessionId:
String, session: SparkSessio
object SessionHolder {
+ // The maxmimum number of errors in the cache.
+ private val ERROR_CACHE_SIZE = 20
+
+ // The maximum time for an error to stay in the cache.
+ private val ERROR_CACHE_TIMEOUT_SEC = 60
+
Review Comment:
20 distinct exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
