HeartSaVioR commented on code in PR #42940:
URL: https://github.com/apache/spark/pull/42940#discussion_r1329424143
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/memory.scala:
##########
@@ -201,7 +207,15 @@ case class MemoryStream[A : Encoder](
override def initialOffset: OffsetV2 = LongOffset(-1)
+ override def prepareForTriggerAvailableNow(): Unit = synchronized {
Review Comment:
While I agree this is a side-effect, this heavily increases a test coverage
as well. We test with three data sources in TriggerAvailableNowSuite, and none
of three supports Trigger.AvailableNow, hence we are basically missing the case
where data source supports Trigger.AvailableNow in that suite. We missed that
for a long time, I'd like to handle this as well, as long as we are here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
