mridulm commented on code in PR #42426:
URL: https://github.com/apache/spark/pull/42426#discussion_r1333300336
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java:
##########
@@ -201,10 +210,17 @@ private synchronized void initiateRetry(Throwable e) {
listener.getTransferType(), retryCount, maxRetries,
outstandingBlocksIds.size(),
retryWaitTime);
- executorService.submit(() -> {
- Uninterruptibles.sleepUninterruptibly(retryWaitTime,
TimeUnit.MILLISECONDS);
- transferAllOutstanding();
- });
+ try {
+ executorService.submit(() -> {
Review Comment:
Let us replace it with `execute` instead.
In future, we will add a checkstyle to prevent `submit` use in general, and
replace with use of `execute` - but that is out of scope for this PR.
Note - this PR is addressing the issue of task submission itself failing,
and not failure after submitting - so change to `execute` wont fix the current
problem: but let us clean this up incrementally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
