LuciferYang commented on code in PR #43121:
URL: https://github.com/apache/spark/pull/43121#discussion_r1337197585
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -2333,7 +2333,7 @@ case class Get(
b
""",
since = "2.4.0",
- group = "map_funcs")
+ group = "collection_funcs")
Review Comment:
https://github.com/apache/spark/blob/2aa06fcf1607bbad9e09649e587493032e739e35/sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java#L110-L116
I think you are right, but from the comments of
`ExpressionDescription#group`, it seems we shouldn't directly use
`collection_funcs`. Perhaps we should amend this comment. On the other hand,
maybe the grouping of other functions needs correction, for instance, should
`Concat` be categorized under `array_funcs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
