beliefer commented on code in PR #43144:
URL: https://github.com/apache/spark/pull/43144#discussion_r1338435883
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1241,6 +1242,23 @@ object OptimizeRepartition extends Rule[LogicalPlan] {
}
}
+/**
+ * Remove window partition if partition expressions are foldable
+ */
+object OptimizeWindowPartitions extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan =
removeWindowExpressionPartitions(plan)
+ .transformWithPruning(_.containsPattern(WINDOW), ruleId) {
+ case w @ Window(_, ps, _, _) =>
+ w.copy(partitionSpec = ps.filter(!_.foldable))
+ }
+
+ def removeWindowExpressionPartitions(plan: LogicalPlan): LogicalPlan =
+
plan.transformAllExpressionsWithPruning(_.containsAnyPattern(WINDOW_EXPRESSION),
ruleId) {
Review Comment:
```suggestion
plan.transformAllExpressionsWithPruning(_.containsPattern(WINDOW_EXPRESSION),
ruleId) {
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1241,6 +1242,23 @@ object OptimizeRepartition extends Rule[LogicalPlan] {
}
}
+/**
+ * Remove window partition if partition expressions are foldable
+ */
+object OptimizeWindowPartitions extends Rule[LogicalPlan] {
Review Comment:
`OptimizeWindowPartitions` -> `EliminateWindowPartitions`
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala:
##########
@@ -513,4 +513,14 @@ class DataFrameWindowFramesSuite extends QueryTest with
SharedSparkSession {
df,
Row(1) :: Row(1) :: Nil)
}
+
+ test("SPARK-45352: Remove window partition if partition expression are
foldable") {
+ val ds = Seq(1, 2, 3).toDF("i")
+ val sortOrder = SortOrder($"i".expr, Ascending)
+ val window1 = new WindowSpec(Seq(), Seq(sortOrder), UnspecifiedFrame)
+ val window2 = new WindowSpec(Seq(lit(1).expr), Seq(sortOrder),
UnspecifiedFrame)
Review Comment:
Please add more test cases:
- partitions only unfoldable.
- Mix unfoldable and foldable partition specs.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1241,6 +1242,23 @@ object OptimizeRepartition extends Rule[LogicalPlan] {
}
}
+/**
+ * Remove window partition if partition expressions are foldable
+ */
+object OptimizeWindowPartitions extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan =
removeWindowExpressionPartitions(plan)
+ .transformWithPruning(_.containsPattern(WINDOW), ruleId) {
+ case w @ Window(_, ps, _, _) =>
+ w.copy(partitionSpec = ps.filter(!_.foldable))
+ }
+
+ def removeWindowExpressionPartitions(plan: LogicalPlan): LogicalPlan =
+
plan.transformAllExpressionsWithPruning(_.containsAnyPattern(WINDOW_EXPRESSION),
ruleId) {
+ case we @ WindowExpression(_, ws @ WindowSpecDefinition(ps, _, _)) =>
Review Comment:
```suggestion
case we @ WindowExpression(_, ws @ WindowSpecDefinition(ps, _, _)) if
ps.exists(_.foldable) =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
