srowen commented on code in PR #42999:
URL: https://github.com/apache/spark/pull/42999#discussion_r1339350784
##########
core/src/main/scala/org/apache/spark/util/Utils.scala:
##########
@@ -2323,31 +2323,75 @@ private[spark] object Utils
* configure a new log4j level
*/
def setLogLevel(l: Level): Unit = {
- val (ctx, loggerConfig) = getLogContext
+ val (ctx, loggerConfig) = getLogContext()
loggerConfig.setLevel(l)
ctx.updateLoggers()
// Setting threshold to null as rootLevel will define log level for
spark-shell
Logging.sparkShellThresholdLevel = null
}
+ /**
+ * configure a new log4j level for specific package or class
+ *
+ * @param name package or class name such as "org.apache.spark" or
+ * "org.apache.spark.SparkContext"
+ * @param level new level of [[org.apache.log4j.Level]]
+ */
+ def setLogLevel(name: String, level: Level): Unit = {
Review Comment:
Oh, nevermind, there were already two overloads? then two new overloads
makes sense.
But yeah they should call each other in a logical way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
