Hisoka-X commented on code in PR #43126:
URL: https://github.com/apache/spark/pull/43126#discussion_r1339915362
##########
mllib/src/main/scala/org/apache/spark/mllib/api/python/GaussianMixtureModelWrapper.scala:
##########
@@ -37,7 +37,7 @@ private[python] class GaussianMixtureModelWrapper(model:
GaussianMixtureModel) {
val modelGaussians = model.gaussians.map { gaussian =>
Array[Any](gaussian.mu, gaussian.sigma)
}
- SerDe.dumps(JavaConverters.seqAsJavaListConverter(modelGaussians).asJava)
+ SerDe.dumps(modelGaussians.toSeq.asJava)
Review Comment:
I'm not sure about we should do this, if we do that, should we change other
`toSeq`? Which `toSeq` need to be modified and which ones do not? Are there any
rules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
