hasnain-db commented on code in PR #43164:
URL: https://github.com/apache/spark/pull/43164#discussion_r1340388063
##########
common/network-common/pom.xml:
##########
@@ -61,6 +61,26 @@
<artifactId>netty-transport-native-kqueue</artifactId>
<classifier>osx-x86_64</classifier>
</dependency>
+ <dependency>
Review Comment:
I don't believe it needs a direct dependency here if you look at the code
changes to `resource-managers/yarn` in
https://github.com/apache/spark/pull/42685 - we do add tests to the yarn code
that do pass.
We do change `ShuffleTransportContext` which is in `network-common`, and
that's what is used by yarn here. `network-yarn` depends on `network-shuffle`
which depends on `network-common` so I think that's how the dependency gets
pulled in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
