mridulm commented on code in PR #43030:
URL: https://github.com/apache/spark/pull/43030#discussion_r1340748033
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala:
##########
@@ -57,6 +57,7 @@ private[spark] class ResourceProfileManager(sparkConf:
SparkConf,
private val isStandaloneOrLocalCluster = master.isDefined && (
master.get.startsWith("spark://") ||
master.get.startsWith("local-cluster")
)
+ private val supportTaskResourceProfile = isStandaloneOrLocalCluster || isYarn
Review Comment:
We should either inline it, or also check whether DRA is disabled - else the
variable is inaccurate.
```suggestion
private val supportTaskResourceProfile = isStandaloneOrLocalCluster ||
(isYarn && !dynamicEnabled)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
