sergioschena-db commented on code in PR #42382:
URL: https://github.com/apache/spark/pull/42382#discussion_r1341006124
##########
python/pyspark/ml/util.py:
##########
@@ -437,7 +437,7 @@ def extractJsonParams(instance: "Params", skipParams:
Sequence[str]) -> Dict[str
def saveMetadata(
instance: "Params",
path: str,
- sc: SparkContext,
+ sparkSession: SparkSession,
Review Comment:
What if I keep the same method signature, with the `sc` and inside it I use
the builder to obtain the spark session object ?
```
val sparkSession = SparkSession.builder.getOrCreate()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
