Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/6300#issuecomment-105284459
I agree @jkbradley and removed the new class. I changed this around a
little in the last commit and I think it's a cleaner. Now `transformImpl`
takes the predict function as a parameter, then the overridden `transform` in a
concrete ensemble classifier/regressor will broadcast the model and bind the
broadcast var to the `predictImpl` where it is accessed. Let me know if this
design seems ok and I'll implement for the other ensembles. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
