itholic commented on code in PR #43214: URL: https://github.com/apache/spark/pull/43214#discussion_r1346778661
########## python/pyspark/pandas/tests/test_numpy_compat.py: ########## @@ -20,7 +20,6 @@ from pyspark import pandas as ps from pyspark.pandas import set_option, reset_option -from pyspark.pandas.numpy_compat import unary_np_spark_mappings, binary_np_spark_mappings Review Comment: Some lines of `numpy_compat.py` call `pandas_udf` which [uses `is_remote()` internally](https://github.com/apache/spark/blob/master/python/pyspark/sql/pandas/functions.py#L509-L514), so we should import `numpy_compat` after initializing the Spark Connect properly when testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
