mridulm commented on code in PR #43220:
URL: https://github.com/apache/spark/pull/43220#discussion_r1346908774
##########
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java:
##########
@@ -257,6 +258,159 @@ public int sslShuffleChunkSize() {
conf.get("spark.network.ssl.maxEncryptedBlockSize", "64k")));
}
+ /**
+ * Whether Secure (SSL/TLS) RPC (including Block Transfer Service) is enabled
+ */
+ public boolean sslRpcEnabled() {
+ return conf.getBoolean("spark.ssl.rpc.enabled", false);
+ }
Review Comment:
Actually, looking at it again, I want to make sure I am not missing
something here.
Currently, `sslRpcEnabledAndKeysAreValid` will return `false` when key store
is specified, but trust store is not - and so ssl factory will be `null`.
Within ssl factory, we do have code to handle the case of trust store being
null resulting in accepting all server certs - but this will never get
triggered since factory is null.
What am I missing here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
