itholic commented on code in PR #43237:
URL: https://github.com/apache/spark/pull/43237#discussion_r1348226460
##########
python/pyspark/pandas/sql_formatter.py:
##########
@@ -200,7 +201,8 @@ def sql(
try:
sdf = session.sql(formatter.format(query, **kwargs), args)
finally:
- formatter.clear()
+ if not is_remote():
+ formatter.clear()
Review Comment:
IMHO it is okay for now since the possibility of side effects is
significantly low enough to ignore, since the name of temp view is generated by
using `uuid.uuid4()` so it's almost no chance of overlap, and also all the temp
views are automatically deleted when the session ends.
Yeah, but I still agree that ideally it would be best to ensure that the
temp view operates properly even after it is deleted from the remote session.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
