beliefer commented on code in PR #43252:
URL: https://github.com/apache/spark/pull/43252#discussion_r1349470930


##########
python/pyspark/sql/dataframe.py:
##########
@@ -897,19 +898,31 @@ def show(self, n: int = 20, truncate: Union[bool, int] = 
True, vertical: bool =
         Parameters
         ----------
         n : int, optional
-            Number of rows to show.
+            Number of rows to show. Default is 20.
         truncate : bool or int, optional
-            If set to ``True``, truncate strings longer than 20 chars by 
default.
+            If set to ``True`` (default), truncate strings longer than 20 
chars.

Review Comment:
   ditto.



##########
python/pyspark/sql/dataframe.py:
##########
@@ -897,19 +898,31 @@ def show(self, n: int = 20, truncate: Union[bool, int] = 
True, vertical: bool =
         Parameters
         ----------
         n : int, optional
-            Number of rows to show.
+            Number of rows to show. Default is 20.

Review Comment:
   I checked all the other cases.
   Shall we change to `default 20. Number of rows to show.` ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to