Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6397#discussion_r30996590
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
@@ -778,41 +692,15 @@ private[spark] class ExternalSorter[K, V, C](
context.taskMetrics.incMemoryBytesSpilled(memoryBytesSpilled)
context.taskMetrics.incDiskBytesSpilled(diskBytesSpilled)
- context.taskMetrics.shuffleWriteMetrics.filter(_ =>
bypassMergeSort).foreach { m =>
--- End diff --
To quickly clarify, this `filter` is equivalent to an `if(bypassMergeSort)`
check. I think that I haven't broken any of the metrics here for the
non-bypass-merge-sort case, but it's a little tricky to tell because
`ExternalSorterSuite` doesn't seem to have any tests that check the
ShuffleWriteMetrics or task metrics. I can look into adding these tests but
I'd like to do it in a separate followup PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
