beliefer commented on code in PR #43280:
URL: https://github.com/apache/spark/pull/43280#discussion_r1349906239
##########
core/src/main/java/org/apache/spark/shuffle/api/ShuffleDriverComponents.java:
##########
@@ -62,12 +62,23 @@ default void registerShuffle(int shuffleId) {}
*/
default void removeShuffle(int shuffleId, boolean blocking) {}
+ /**
+ * This method is for compatibility with older implementations
+ * the implementation should just directly return true
+ * when use distributed filesystem or in a disaggregated shuffle cluster
+ */
Review Comment:
Shall we keep the origin comments here and add these new comments as `Note:
...` at last?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
