hasnain-db commented on code in PR #43289:
URL: https://github.com/apache/spark/pull/43289#discussion_r1350364095


##########
common/network-yarn/pom.xml:
##########
@@ -110,6 +110,7 @@
                 <exclude>META-INF/*.SF</exclude>
                 <exclude>META-INF/*.DSA</exclude>
                 <exclude>META-INF/*.RSA</exclude>
+                <exclude>META-INF/license/*</exclude>

Review Comment:
   @srowen I'll try the initial attempt of this PR then - we just remove a 
single file called LICENSE which is the apache2 license and is identical to a 
LICENSE.txt that is still going to be in the final jar. If that works (testing 
now), would it be ok? IMO it's preferable as then we don't need to update the 
license-binary dir and it's also future proof in case the contents of the 
directory change. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to