beliefer commented on code in PR #43303:
URL: https://github.com/apache/spark/pull/43303#discussion_r1351432373
##########
core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala:
##########
@@ -210,22 +210,59 @@ private[deploy] object JsonProtocol {
* `status` status of the master,
* see [[org.apache.spark.deploy.master.RecoveryState.MasterState]]
*/
- def writeMasterState(obj: MasterStateResponse): JObject = {
+ def writeMasterState(field: Option[String], obj: MasterStateResponse):
JObject = {
Review Comment:
Uh, I missed the signature. Could we put `field: Option[String]` as the last
parameter?
It seems give a default `None` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
