beliefer commented on code in PR #43259:
URL: https://github.com/apache/spark/pull/43259#discussion_r1354320494


##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -760,13 +760,13 @@ class CatalogImpl(sparkSession: SparkSession) extends 
Catalog {
   }
 
   /**
-   * Caches the specified table or view in-memory.
+   * Persist the specified table or view with the default storage level,

Review Comment:
   Before this change, `persist` surely write data to disk(means persistent) no 
matter how many times the user calls.
   
   After this change, `persist` may not write data to disk if some user change 
the default storage level with `only_memory`.
   
   So I think this change make a break change. It seems not change the logic is 
better. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to