ueshin commented on code in PR #43204:
URL: https://github.com/apache/spark/pull/43204#discussion_r1355452243
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/BatchEvalPythonUDTFExec.scala:
##########
@@ -132,7 +135,15 @@ object PythonUDTFRunner {
case None =>
dataOut.writeInt(0)
}
+ // Write the pickled AnalyzeResult buffer from the UDTF "analyze" method,
if any.
+ dataOut.writeBoolean(udtf.pickledAnalyzeResult.nonEmpty)
+ udtf.pickledAnalyzeResult.map { p =>
Review Comment:
nit: `foreach` instead of `map`?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/UserDefinedPythonFunction.scala:
##########
@@ -284,6 +285,14 @@ object UserDefinedPythonTableFunction {
val schema = DataType.fromJson(
PythonWorkerUtils.readUTF(length, dataIn)).asInstanceOf[StructType]
+ // Receive the pickled AnalyzeResult buffer, if any.
+ val pickledAnalyzeResult: Array[Byte] = dataIn.readInt() match {
+ case length =>
+ val obj = new Array[Byte](length)
+ dataIn.readFully(obj)
+ obj
+ }
Review Comment:
Shall we use `PythonWorkerUtils.readBytes` as
https://github.com/apache/spark/pull/43321 is merged?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/BatchEvalPythonUDTFExec.scala:
##########
@@ -132,7 +135,15 @@ object PythonUDTFRunner {
case None =>
dataOut.writeInt(0)
}
+ // Write the pickled AnalyzeResult buffer from the UDTF "analyze" method,
if any.
+ dataOut.writeBoolean(udtf.pickledAnalyzeResult.nonEmpty)
+ udtf.pickledAnalyzeResult.map { p =>
+ dataOut.writeInt(p.length)
+ dataOut.write(p)
Review Comment:
ditto, `PythonWorkerUtils.writeBytes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
