shujingyang-db commented on code in PR #43319: URL: https://github.com/apache/spark/pull/43319#discussion_r1355376309
########## sql/core/src/test/resources/test-data/xml-resources/root-level-value.xml: ########## @@ -0,0 +1,9 @@ +<?xml version="1.0"?> +<ROWSET> + <ROW>value1</ROW> + <ROW attr="attr1">value2</ROW> + <ROW> + value3 + <!-- this is a comment--> + </ROW> +</ROWSET> Review Comment: Sure I will add another test case for this. In this case, `5` and `6` will also be skipped. We only read values if the struct only consists of attributes and `valueTag`. If there's another field (i.e. `tag`), the value in between the tags will be ignored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
