JoshRosen commented on code in PR #43344:
URL: https://github.com/apache/spark/pull/43344#discussion_r1355953702
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java:
##########
@@ -157,4 +157,11 @@ public void heapMemoryReuse() {
Assertions.assertEquals(1024 * 1024 + 7, onheap4.size());
Assertions.assertEquals(obj3, onheap4.getBaseObject());
}
+
+ @Test
+ public void cleanerCreateMethodIsDefined() {
+ // Regression test for SPARK-45508: we don't expect the "no cleaner"
fallback
+ // path to be hit in normal usage.
+ Assertions.assertTrue(Platform.cleanerCreateMethodIsDefined());
Review Comment:
If we want to backport this change then we will have to prepare a separate
PR because https://github.com/apache/spark/pull/43074 changed the JUnit
assertions helper names so the same source can't compile in all branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
