beliefer commented on code in PR #41855:
URL: https://github.com/apache/spark/pull/41855#discussion_r1356421158
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -104,34 +105,6 @@ object JdbcUtils extends Logging with SQLConfHelper {
JdbcDialects.get(url).isCascadingTruncateTable()
}
- /**
- * Returns an Insert SQL statement for inserting a row into the target table
via JDBC conn.
- */
- def getInsertStatement(
- table: String,
- rddSchema: StructType,
- tableSchema: Option[StructType],
- isCaseSensitive: Boolean,
Review Comment:
The origin interface keep the `isCaseSensitive` is useful, even if it was
not used in the code directly.
It seems we'd better add `isCaseSensitive` to the
`JdbcDialect.insertIntoTable`.
Maybe some jdbc dialect is case sensitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
