beliefer commented on code in PR #42317:
URL: https://github.com/apache/spark/pull/42317#discussion_r1356628946
##########
sql/core/src/test/scala/org/apache/spark/sql/InjectRuntimeFilterSuite.scala:
##########
@@ -390,34 +390,60 @@ class InjectRuntimeFilterSuite extends QueryTest with
SQLTestUtils with SharedSp
test("Runtime bloom filter join: two joins") {
withSQLConf(SQLConf.RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD.key
-> "3000",
SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "2000") {
+ // bf2 as creation side and inject runtime filter for bf1 and bf3.
assertRewroteWithBloomFilter("select * from bf1 join bf2 join bf3 on
bf1.c1 = bf2.c2 " +
"and bf3.c3 = bf2.c2 where bf2.a2 = 5", 2)
- assertRewroteWithBloomFilter("select * from (select * from bf1 left semi
join bf2 on " +
- "bf1.c1 = bf2.c2 where bf1.a1 = 5) as a join bf3 on bf3.c3 = a.c1")
- assertRewroteWithBloomFilter("select * from (select * from bf1 left anti
join bf2 on " +
- "bf1.c1 = bf2.c2 where bf1.a1 = 5) as a join bf3 on bf3.c3 = a.c1")
assertRewroteWithBloomFilter("select * from bf1 left outer join bf2 join
bf3 on " +
"bf1.c1 = bf2.c2 and bf3.c3 = bf2.c2 where bf2.a2 = 5", 2)
assertRewroteWithBloomFilter("select * from bf1 right outer join bf2
join bf3 on " +
"bf1.c1 = bf2.c2 and bf3.c3 = bf2.c2 where bf2.a2 = 5", 2)
+ // bf1 and bf2 hasn't shuffle. bf1 as creation side and inject runtime
filter for bf3.
+ assertRewroteWithBloomFilter("select * from (select * from bf1 left semi
join bf2 on " +
Review Comment:
Here are two aspects:
One of these test cases, I recently found out that I forgot why and inserted
runtime filter. Which specific point is being tested?
On the other hand, I have grouped the same type together. Otherwise, it
looks a bit messy.
So, I organized it today and added which case to test. It also facilitates
readability for developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
