cloud-fan commented on code in PR #41860:
URL: https://github.com/apache/spark/pull/41860#discussion_r1357690520
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -311,6 +317,10 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
case join @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, _, _,
left, right, hint) =>
var newLeft = left
var newRight = right
+ // Whether it is a shuffle join or not should be based on the actual
left and
+ // right table. For some join like left outer join, it will be a
shuffle join
+ // even if left side table size is smaller than broadcast threshold.
Review Comment:
this comment is useful but should be put in the definition side of
`isProbablyShuffleJoin`, not the caller side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
