cloud-fan commented on code in PR #43359:
URL: https://github.com/apache/spark/pull/43359#discussion_r1357704746


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -29,7 +29,9 @@ import org.apache.spark.sql.internal.SQLConf
 import org.apache.spark.sql.types._
 
 /**
- * Insert a filter on one side of the join if the other side has a selective 
predicate.
+ * Insert a runtime filter on one side of the join (we call this side the 
application side) if
+ * we can extract a runtime filter from the other side (creation side). A 
simple case is that
+ * the creation side is a table scan with a selective filter.
  * The filter could be an IN subquery (converted to a semi join), a bloom 
filter, or something

Review Comment:
   ```suggestion
    * The runtime filter could be an IN subquery (converted to a semi join), a 
bloom filter, or something
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to