LuciferYang commented on code in PR #43349:
URL: https://github.com/apache/spark/pull/43349#discussion_r1357910675
##########
common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java:
##########
@@ -65,38 +65,26 @@ public static ThreadFactory createThreadFactory(String
threadPoolPrefix) {
public static EventLoopGroup createEventLoop(IOMode mode, int numThreads,
String threadPrefix) {
ThreadFactory threadFactory = createThreadFactory(threadPrefix);
- switch (mode) {
- case NIO:
- return new NioEventLoopGroup(numThreads, threadFactory);
- case EPOLL:
- return new EpollEventLoopGroup(numThreads, threadFactory);
- default:
- throw new IllegalArgumentException("Unknown io mode: " + mode);
- }
+ return switch (mode) {
+ case NIO -> new NioEventLoopGroup(numThreads, threadFactory);
+ case EPOLL -> new EpollEventLoopGroup(numThreads, threadFactory);
Review Comment:
Compilation failed if we just add a new IOMode item, like
```
[error]
/Users/yangjie01/SourceCode/git/spark-mine-sbt/common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java:68:1:
错误: switch 表达式不包含所有可能的输入值
[error] return switch (mode) {
[error] ^
[warn] javac exited with exit code 1
[error] (network-common / Compile / compileIncremental) javac returned
non-zero exit code
[error] Total time: 7 s, completed 2023年10月13日 下午3:42:54
```
##########
common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java:
##########
@@ -65,38 +65,26 @@ public static ThreadFactory createThreadFactory(String
threadPoolPrefix) {
public static EventLoopGroup createEventLoop(IOMode mode, int numThreads,
String threadPrefix) {
ThreadFactory threadFactory = createThreadFactory(threadPrefix);
- switch (mode) {
- case NIO:
- return new NioEventLoopGroup(numThreads, threadFactory);
- case EPOLL:
- return new EpollEventLoopGroup(numThreads, threadFactory);
- default:
- throw new IllegalArgumentException("Unknown io mode: " + mode);
- }
+ return switch (mode) {
+ case NIO -> new NioEventLoopGroup(numThreads, threadFactory);
+ case EPOLL -> new EpollEventLoopGroup(numThreads, threadFactory);
Review Comment:
Compilation failed if we just add a new IOMode item, like
```
[error]
/Users/yangjie01/SourceCode/git/spark-mine-sbt/common/network-common/src/main/java/org/apache/spark/network/util/NettyUtils.java:68:1:
错误: switch 表达式不包含所有可能的输入值
[error] return switch (mode) {
[error] ^
[warn] javac exited with exit code 1
[error] (network-common / Compile / compileIncremental) javac returned
non-zero exit code
[error] Total time: 7 s, completed 2023年10月13日 下午3:42:54
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
