heyihong commented on code in PR #43352:
URL: https://github.com/apache/spark/pull/43352#discussion_r1358592923


##########
python/pyspark/sql/connect/proto/base_pb2.pyi:
##########
@@ -2869,6 +2869,59 @@ class 
FetchErrorDetailsResponse(google.protobuf.message.Message):
             self, oneof_group: typing_extensions.Literal["_file_name", 
b"_file_name"]
         ) -> typing_extensions.Literal["file_name"] | None: ...
 
+    class QueryContext(google.protobuf.message.Message):

Review Comment:
   Not yet if I understand correctly. @gatorsmile has some concern on whether 
exposing QueryContext in the PySpark Exception APIs makes sense for non-sql 
PySpark exceptions. There is some ongoing discussion for this.



##########
python/pyspark/sql/connect/proto/base_pb2.pyi:
##########
@@ -2869,6 +2869,59 @@ class 
FetchErrorDetailsResponse(google.protobuf.message.Message):
             self, oneof_group: typing_extensions.Literal["_file_name", 
b"_file_name"]
         ) -> typing_extensions.Literal["file_name"] | None: ...
 
+    class QueryContext(google.protobuf.message.Message):

Review Comment:
   Not yet if I understand correctly. @gatorsmile has some concern about 
whether exposing QueryContext in the PySpark Exception APIs makes sense for 
non-sql PySpark exceptions. There is some ongoing discussion for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to