heyihong commented on code in PR #43368: URL: https://github.com/apache/spark/pull/43368#discussion_r1360531140
########## sql/api/src/main/scala/org/apache/spark/sql/catalyst/analysis/alreadyExistException.scala: ########## @@ -31,7 +31,7 @@ class DatabaseAlreadyExistsException(db: String) extends NamespaceAlreadyExistsException(Array(db)) // any changes to this class should be backward compatible as it may be used by external connectors -class NamespaceAlreadyExistsException private( +class NamespaceAlreadyExistsException private[sql]( Review Comment: These exception are moved from `sql/catalyst` module to `sql/api` moduel and I am not sure if the assumption still holds for them. Also, according to the comment above: ``` any changes to this class should be backward compatible as it may be used by external connectors ``` It may be safe to keep the `private[sql]`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
