mridulm commented on code in PR #43371:
URL: https://github.com/apache/spark/pull/43371#discussion_r1360946397
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1864,35 +1871,27 @@ private void finalizePartition() throws IOException {
metaFile.getChannel().truncate(metaFile.getPos());
}
- void closeAllFilesAndDeleteIfNeeded(boolean delete) {
+ private void deleteAllFiles() {
try {
- if (dataChannel.isOpen()) {
- dataChannel.close();
- }
- if (delete) {
- dataFile.delete();
- }
- } catch (IOException ioe) {
- logger.warn("Error closing data channel for {} reduceId {}",
+ if (!dataFile.delete()) {
+ logger.warn("Error deleting data file for {} reduceId {}",
appAttemptShuffleMergeId, reduceId);
+ }
+ } catch (Exception exception) {
+ logger.warn("Error deleting data file for {} reduceId {}",
+ appAttemptShuffleMergeId, reduceId);
}
try {
- metaFile.close();
- if (delete) {
- metaFile.delete();
- }
+ metaFile.delete();
} catch (IOException ioe) {
- logger.warn("Error closing meta file for {} reduceId {}",
- appAttemptShuffleMergeId, reduceId);
- }
+ logger.warn("Error deleting meta file for {} reduceId {}",
+ appAttemptShuffleMergeId, reduceId);
+ }
Review Comment:
Drop all `IOException` catch blocks in this method - they are not thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
