HyukjinKwon commented on code in PR #43389: URL: https://github.com/apache/spark/pull/43389#discussion_r1361380449
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/xml/XmlOptions.scala: ########## @@ -63,8 +63,10 @@ private[sql] class XmlOptions( } val compressionCodec = parameters.get(COMPRESSION).map(CompressionCodecs.getCodecClassName) - val rowTag = parameters.getOrElse(ROW_TAG, XmlOptions.DEFAULT_ROW_TAG) - require(rowTag.nonEmpty, s"'$ROW_TAG' option should not be empty string.") + val rowTagOpt = parameters.get(ROW_TAG) + require(rowTagOpt.isDefined, s"'$ROW_TAG' option is required.") Review Comment: While I agree with the logic, I think we should probably add a conf to restore this behaviour back (at `SQLConf`) because we now change the default behaviour. Should also probably add a note at https://github.com/apache/spark/blob/master/docs/sql-migration-guide.md Otherwise LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
