cloud-fan commented on code in PR #42317:
URL: https://github.com/apache/spark/pull/42317#discussion_r1362090110
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -331,8 +352,8 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
val hasShuffle = isProbablyShuffleJoin(left, right, hint)
if (canPruneLeft(joinType) && (hasShuffle ||
probablyHasShuffle(left))) {
extractBeneficialFilterCreatePlan(left, right, l, r).foreach {
- filterCreationSidePlan =>
- newLeft = injectFilter(l, newLeft, r, filterCreationSidePlan)
+ case (filterCreationSideExp, filterCreationSidePlan) =>
Review Comment:
```suggestion
case (filterCreationSideKey, filterCreationSidePlan) =>
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -341,8 +362,9 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
if (newLeft.fastEquals(oldLeft) && canPruneRight(joinType) &&
(hasShuffle || probablyHasShuffle(right))) {
extractBeneficialFilterCreatePlan(right, left, r, l).foreach {
- filterCreationSidePlan =>
- newRight = injectFilter(r, newRight, l,
filterCreationSidePlan)
+ case (filterCreationSideExp, filterCreationSidePlan) =>
Review Comment:
```suggestion
case (filterCreationSideKey, filterCreationSidePlan) =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
