cloud-fan commented on code in PR #43419:
URL: https://github.com/apache/spark/pull/43419#discussion_r1363168515
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala:
##########
@@ -299,6 +301,11 @@ case class TakeOrderedAndProjectExec(
}
}
+ private def prepareAndWaitForSubqueries(): Unit = {
Review Comment:
instead of adding this method, shall we just call `executeQuery` in
`executeCollect`?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala:
##########
@@ -283,6 +283,8 @@ case class TakeOrderedAndProjectExec(
}
override def executeCollect(): Array[InternalRow] = {
Review Comment:
```suggestion
override def executeCollect(): Array[InternalRow] = executeQuery {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
