mridulm commented on code in PR #43409:
URL: https://github.com/apache/spark/pull/43409#discussion_r1363176084
##########
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala:
##########
@@ -203,7 +211,7 @@ private[storage] class BlockManagerDecommissioner(
@volatile private var stopped = false
@volatile private[storage] var stoppedRDD =
!conf.get(config.STORAGE_DECOMMISSION_RDD_BLOCKS_ENABLED)
- @volatile private var stoppedShuffle =
+ @volatile private[storage] var stoppedShuffle =
Review Comment:
Instead of exposing the volatile boolean, add a method to expose the current
value read only.
```suggestion
@volatile private var stoppedShuffle =
!conf.get(config.STORAGE_DECOMMISSION_SHUFFLE_BLOCKS_ENABLED)
private[storage] def isShuffleStopped: Boolean = stoppedShuffle
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
