HyukjinKwon commented on code in PR #43360:
URL: https://github.com/apache/spark/pull/43360#discussion_r1363404498
##########
python/pyspark/sql/readwriter.py:
##########
@@ -69,20 +82,26 @@ class DataFrameReader(OptionUtils):
def __init__(self, spark: "SparkSession"):
self._jreader = spark._jsparkSession.read()
self._spark = spark
+ self._format: Optional[Union[str, Type[DataSource]]] = None
+ self._schema: Optional[Union[str, StructType]] = None
+ self._options: Dict[str, "OptionalPrimitiveType"] = dict()
Review Comment:
All these have to be removed. In theory, `DataFrameReader` should not have
any change, and the Python sources are only referenced by `format` short name.
So yes I would like to separate them somewhere to make it easier to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
